Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #429 generic type #696

Closed
wants to merge 3 commits into from
Closed

Fix #429 generic type #696

wants to merge 3 commits into from

Conversation

SDGGiesbrecht
Copy link
Contributor

Fixes issue #429 by filtering out instances of source.lang.swift.decl.generic_type_param and ignoring those undocumented symbols. Unless I am mistaken, it is not currently possible to document such a symbol even if one wanted to. You can see the difference in action by running the test in my last comment on the issue.

@SDGGiesbrecht
Copy link
Contributor Author

I read the details of the continuous integration checks.

The unit tests only fail because undocumented.json no longer contains the false positives the tests are expecting. Removing those false positives was the whole point.

@istx25, do you have enough access as a collaborator to make sure the pull request doesn’t get ignored because of the big red x?

@pigeondotdev
Copy link
Contributor

Thanks for filing this PR, @SDGGiesbrecht. We'll try to get this merged in as soon as possible. I'm still familiarizing myself with how the inners of the project/specs work. I'm going to rope in @jpsim and @segiddins. Could you help us with this?

@jpsim
Copy link
Collaborator

jpsim commented Dec 12, 2016

@SDGGiesbrecht thanks for the PR! Integration specs are kept in a separate repo to avoid repo bloat: https://github.com/realm/jazzy-integration-specs

it's included in the jazzy repo as a git submodule under spec/integration_specs. To rebuild them, simply run rake rebuild_integration_fixtures, then you can make a PR towards the realm/jazzy-integration-specs repo to include the change upstream.

Since this PR looks good as-is, I'll take care of this today.

@jpsim
Copy link
Collaborator

jpsim commented Dec 12, 2016

One thing to keep in mind is that you'll need the same version of Xcode installed and xcode-selected locally when rebuilding the specs as jazzy runs in Travis, which is Xcode 7.3.1 at the moment.

jpsim added a commit to realm/jazzy-integration-specs that referenced this pull request Dec 12, 2016
@jpsim jpsim mentioned this pull request Dec 12, 2016
@jpsim
Copy link
Collaborator

jpsim commented Dec 12, 2016

Continuing in #698. Thanks @SDGGiesbrecht. Both your PRs were great by the way, I really hope you continue contributing to jazzy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants